Add hjoshi123 as reviewer - #424
Merged
cert-manager-prow[bot] merged 1 commit intoSep 9, 2025
Merged
Conversation
Signed-off-by: hjoshi123 <mail@hjoshi.me>
cert-manager-prow
Bot
added
the
dco-signoff: yes
cert-manager-prow
Bot
added
the
size/XS
erikgb
reviewed
Sep 9, 2025
erikgb
left a comment
erikgb
left a comment
Member
There was a problem hiding this comment.
Thanks for helping out with reviews in this project, @hjoshi123! As most maintainers are busy with other stuff right now, it would be super with some help in getting (my) PRs through.
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
hjoshi123as a reviewer in makefile-modules.Have reviewed and contributed several PR's in makefile modules as shown below:
https://github.com/cert-manager/makefile-modules/pulls?q=is%3Apr+author%3Ahjoshi123+is%3Aclosed
#420
Sponsor:
@erikgb